Merged
Conversation
mkarg
requested review from
arjantijms,
chkal,
jamezp,
jansupol,
jim-krueger and
spericas
jansupol
reviewed
Dec 21, 2024
jaxrs-tck/src/main/resources/ee/jakarta/tck/ws/rs/signaturetest/jakarta.ws.rs.sig_3.2.0
Show resolved
Hide resolved
Contributor
|
Hm...the commit will be forever titled Remove Service Manager instead of Security Manager in the git history.... |
Contributor
Author
Good catch, and thank you for changing the typo, but actually it will not show up in git history anyways: The commit itself does not have the typo, and when using "Rebase and merge" in Github, the title of the PR will not show up in the git history. 🙂 |
Contributor
|
You are right, sorry, I have not checked the commit message |
spericas
approved these changes
Jan 3, 2025
This was referenced Feb 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the support for Security Manager.
closes #1262
Requesting fast-track according to our Committer Conventions, as this PR is a non-API, non-spec, non-javadoc change.